Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.editorconfig: Added .editorconfig file #643

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

.editorconfig: Added .editorconfig file #643

wants to merge 2 commits into from

Conversation

shakeelsamsu
Copy link

@shakeelsamsu shakeelsamsu commented Nov 5, 2018

Added .editorconfig file for Python and YAML

Closes #331

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

Copy link
Member

@nvzard nvzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify your commit message as per the commit guidelines :)
http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

@shakeelsamsu
Copy link
Author

Done.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task requires adding .editorconfig to the sync list in .moban.yaml

Commit message doesnt comply with https://coala.io/commit .

@shakeelsamsu shakeelsamsu changed the title Added .editorconfig file .editorconfig: Added .editorconfig file Nov 6, 2018
[**]
charset = utf-8
end_of_line = lf
insert_final_newline = truemax_line_length = 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the .. this doesnt look right....

Copy link
Member

@nkprince007 nkprince007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .editorconfig.jj2template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants