Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: CNF Installation (5.1) Test preparation for new installation #2163

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Feature: CNF Installation (5.1) Test preparation for new installation #2163

merged 1 commit into from
Oct 29, 2024

Conversation

barmull
Copy link
Collaborator

@barmull barmull commented Oct 3, 2024 •
edited by martin-mat
Loading

Description

  • open_metrics and prometheus_traffic - changed config map naming
  • ip_addresses - removed, fully replaced by hardcoded_ip_addresses_in_k8s_runtime_configuration
  • hardcoded_ip_addresses_in_k8s_runtime_configuration - change to use common_manifest.yml file

Issues:

Refs: #2153

@barmull barmull force-pushed the #2153-tests-preparation(5.1) branch from 0866145 to f767599 Compare October 4, 2024 13:03
@kosstennbl kosstennbl marked this pull request as draft October 7, 2024 09:14
@barmull barmull force-pushed the #2153-tests-preparation(5.1) branch from f767599 to e1c786a Compare October 8, 2024 12:46
@martin-mat martin-mat self-requested a review October 14, 2024 09:13
martin-mat
martin-mat requested changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add reasoning for removing ip_address to the commit message.

tools/curl_install_tester_docker_setup/Dockerfile Outdated Show resolved Hide resolved
@barmull barmull force-pushed the #2153-tests-preparation(5.1) branch 3 times, most recently from 3414f25 to 88d49a0 Compare October 22, 2024 15:02
kosstennbl
kosstennbl approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be ready to merge after (4), CI checks and approvals

svteb
svteb approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat
Copy link
Collaborator

needs rebase

@barmull
Feature: CNF Installation (5.1) - test preparation
9f1ddc1 
- open_metrics and prometheus_traffic - change name of config maps
- ip_addresses - removed
- hardcoded_ip_addresses_in_k8s_runtime_configuration -
  change to use common_manifest.yml file

Refs: #2153
Signed-off-by: barmull [email protected]
@barmull barmull force-pushed the #2153-tests-preparation(5.1) branch from 88d49a0 to 9f1ddc1 Compare October 24, 2024 14:22
@barmull
Copy link
Collaborator Author

barmull commented Oct 24, 2024

rebased on main

@kosstennbl kosstennbl marked this pull request as ready for review October 25, 2024 07:41
@martin-mat martin-mat self-requested a review October 29, 2024 07:17
martin-mat
martin-mat approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

collivier
collivier approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@collivier collivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat martin-mat merged commit 0c56bd8 into main Oct 29, 2024
165 of 170 checks passed
@martin-mat martin-mat deleted the #2153-tests-preparation(5.1) branch October 29, 2024 11:29
@svteb svteb mentioned this pull request Nov 4, 2024
Closed
4 tasks
This was referenced Nov 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svteb svteb svteb approved these changes

@kosstennbl kosstennbl kosstennbl approved these changes

@martin-mat martin-mat martin-mat approved these changes

@collivier collivier collivier approved these changes

@denverwilliams denverwilliams Awaiting requested review from denverwilliams denverwilliams is a code owner

@agentpoyo agentpoyo Awaiting requested review from agentpoyo agentpoyo is a code owner

@HashNuke HashNuke Awaiting requested review from HashNuke HashNuke is a code owner

@Smitholi67 Smitholi67 Awaiting requested review from Smitholi67

@rich-l rich-l Awaiting requested review from rich-l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barmull @martin-mat @collivier @kosstennbl @svteb