Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-generator: CNF Installation (2.2) Add generator for v2 config #2148

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kosstennbl
Copy link
Collaborator

Description

Create new config generation task, that would generate v2 config.
This task should be more interactable and friendly to new testsuite users.

Issues:

Refs: #2138

Re-created from different branch, old PR: #2142

src/tasks/cnf_setup.cr Outdated Show resolved Hide resolved
src/tasks/cnf_setup.cr Outdated Show resolved Hide resolved
src/tasks/cnf_setup.cr Outdated Show resolved Hide resolved
Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kosstennbl kosstennbl force-pushed the #2138-new-config-generator branch 3 times, most recently from a74f63b to 3557e12 Compare September 23, 2024 08:55
@kosstennbl kosstennbl marked this pull request as ready for review September 26, 2024 15:12
Create new config generation task, that would generate v2 config.
This tas should be more interactable and friendly to new
testsuite users.

Refs: #2138
Signed-off-by: Konstantin Yarovoy <[email protected]>
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-mat martin-mat merged commit 836581a into main Sep 27, 2024
170 of 174 checks passed
@kosstennbl kosstennbl deleted the #2138-new-config-generator branch September 30, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants