-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config-generator: CNF Installation (2.2) Add generator for v2 config #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-mat
requested changes
Sep 17, 2024
svteb
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kosstennbl
force-pushed
the
#2138-new-config-generator
branch
3 times, most recently
from
September 23, 2024 08:55
a74f63b
to
3557e12
Compare
kosstennbl
force-pushed
the
#2138-new-config-generator
branch
from
September 23, 2024 11:46
3557e12
to
3d7e55e
Compare
kosstennbl
requested review from
denverwilliams and
agentpoyo
as code owners
September 26, 2024 15:12
Create new config generation task, that would generate v2 config. This tas should be more interactable and friendly to new testsuite users. Refs: #2138 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
force-pushed
the
#2138-new-config-generator
branch
from
September 27, 2024 07:42
3d7e55e
to
1f7fad7
Compare
martin-mat
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Smitholi67
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new config generation task, that would generate v2 config.
This task should be more interactable and friendly to new testsuite users.
Issues:
Refs: #2138
Re-created from different branch, old PR: #2142