Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix: remove protected image repo spec test #2137

Merged

Conversation

martin-mat
Copy link
Collaborator

After #2114 was merged, an issue was revealed
with image size - protected repo spec test.
It was discovered only after merging.
Until this is fixed, disabling this variant
of the image size spec test.

Refs: #2114 #2136

Copy link
Collaborator

@svteb svteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe correct the indentation a little.

After cnti-testcatalog#2114 was merged, an issue was revealed
with image size - protected repo spec test.
It was discovered only after merging.
Until this is fixed, disabling this variant
of the image size spec test.

Refs: cnti-testcatalog#2114 cnti-testcatalog#2136

Signed-off-by: Martin Matyas <[email protected]>
Copy link
Collaborator

@kosstennbl kosstennbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, temporary disabled, later should be reviewed to be deleted or fixed

Copy link
Collaborator

@Smitholi67 Smitholi67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martin-mat martin-mat merged commit 11aeb49 into cnti-testcatalog:main Aug 16, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants