Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow to specify deployment order in cnfs that have multiple deployments #2176

Open
svteb opened this issue Nov 11, 2024 · 0 comments
Open

[Feature] Allow to specify deployment order in cnfs that have multiple deployments #2176

svteb opened this issue Nov 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@svteb
Copy link
Collaborator

svteb commented Nov 11, 2024

Is your feature request related to a problem? Please describe.
During testing of the new installation method introduced in #2165 I noticed that some cnfs might fail to setup/cleanup properly if they are installed/uninstalled in the incorrect order. This happened specifically with elk stack deployment, where a post-delete kibana pod was stuck in CreatingContainer state because elasticsearch was deleted before kibana.

Describe the solution you'd like
We should add an optional tag to config with the install order, unless I am mistaken the uninstall order should then just be the install order but reversed to get the proper result.

How will this be tested? aka Acceptance Criteria (optional)
Add a new a spec test that will verify this (there is an elk stack sample already).
@svteb svteb added the enhancement New feature or request label Nov 11, 2024
svteb added a commit that referenced this issue Nov 12, 2024
@svteb
Feat: Add spec tests for new installation method and fix minor bugs
5531b22 
Refs: #2168
- New setup spec tests were introduced to verify that the installation
  method from #2161 works as intended.
- Three distinct issues were discovered and resolved:
  * Helm directories with variable depth levels could not be discovered
  after initialization (resolved through File.basename).
  * Configs that weren't named cnf-testsuite.yml could not
  be discovered after initialization (resolved by changing the name
  internally when copying the file).
  * Existence of manifest folder was not checked (resolved by adding an
  if check).
- Additionally a common point of failure was added with a failure
  message that was previously not present.
- The issue #2176 was also discovered during attempted deployment of
  sample-cnfs/sample-elk-stack which was also added in this commit and
  is to be used in future spec test.

Signed-off-by: svteb <[email protected]>
@svteb svteb mentioned this issue Nov 12, 2024
Merged
20 tasks
svteb added a commit that referenced this issue Nov 13, 2024
@svteb
Feat: Add spec tests for new installation method and fix minor bugs
df63e7a 
Refs: #2168
- New setup spec tests were introduced to verify that the installation
  method from #2161 works as intended.
- Three distinct issues were discovered and resolved:
  * Helm directories with variable depth levels could not be discovered
  after initialization (resolved through File.basename).
  * Configs that weren't named cnf-testsuite.yml could not
  be discovered after initialization (resolved by changing the name
  internally when copying the file).
  * Existence of manifest folder was not checked (resolved by adding an
  if check).
- Additionally a common point of failure was added with a failure
  message that was previously not present.
- The issue #2176 was also discovered during attempted deployment of
  sample-cnfs/sample-elk-stack which was also added in this commit and
  is to be used in future spec test.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Nov 14, 2024
@svteb
Feat: Add spec tests for new installation method and fix minor bugs
7621efb 
Refs: #2168
- New setup spec tests were introduced to verify that the installation
  method from #2161 works as intended.
- Three distinct issues were discovered and resolved:
  * Helm directories with variable depth levels could not be discovered
  after initialization (resolved through File.basename).
  * Configs that weren't named cnf-testsuite.yml could not
  be discovered after initialization (resolved by changing the name
  internally when copying the file).
  * Existence of manifest folder was not checked (resolved by adding an
  if check).
- Additionally a common point of failure was added with a failure
  message that was previously not present.
- The issue #2176 was also discovered during attempted deployment of
  sample-cnfs/sample-elk-stack which was also added in this commit and
  is to be used in future spec test.

Signed-off-by: svteb <[email protected]>
kosstennbl pushed a commit that referenced this issue Nov 22, 2024
installation: Add possibility to specify installation order
081c44b 
Add installation_priority parameter for specification of order
for installation of deployments.

Refs: #2176
Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue Nov 22, 2024
Open
collivier pushed a commit that referenced this issue Nov 27, 2024
@svteb @collivier
Feat: Add spec tests for new installation method and fix minor bugs
f06c51f 
Refs: #2168
- New setup spec tests were introduced to verify that the installation
  method from #2161 works as intended.
- Three distinct issues were discovered and resolved:
  * Helm directories with variable depth levels could not be discovered
  after initialization (resolved through File.basename).
  * Configs that weren't named cnf-testsuite.yml could not
  be discovered after initialization (resolved by changing the name
  internally when copying the file).
  * Existence of manifest folder was not checked (resolved by adding an
  if check).
- Additionally a common point of failure was added with a failure
  message that was previously not present.
- The issue #2176 was also discovered during attempted deployment of
  sample-cnfs/sample-elk-stack which was also added in this commit and
  is to be used in future spec test.

Signed-off-by: svteb <[email protected]>
svteb added a commit that referenced this issue Nov 28, 2024
@svteb
Feat: Add spec tests for new installation method and fix minor bugs
8c37d23 
Refs: #2168
- New setup spec tests were introduced to verify that the installation
  method from #2161 works as intended.
- Three distinct issues were discovered and resolved:
  * Helm directories with variable depth levels could not be discovered
  after initialization (resolved through File.basename).
  * Configs that weren't named cnf-testsuite.yml could not
  be discovered after initialization (resolved by changing the name
  internally when copying the file).
  * Existence of manifest folder was not checked (resolved by adding an
  if check).
- Additionally a common point of failure was added with a failure
  message that was previously not present.
- The issue #2176 was also discovered during attempted deployment of
  sample-cnfs/sample-elk-stack which was also added in this commit and
  is to be used in future spec test.

Signed-off-by: svteb <[email protected]>
kosstennbl pushed a commit that referenced this issue Nov 29, 2024
installation: Add possibility to specify installation order
0457316 
Add installation_priority parameter for specification of order
for installation of deployments.

Refs: #2176
Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl pushed a commit that referenced this issue Dec 3, 2024
installation: Add possibility to specify installation order
98f99bb 
Add installation_priority parameter for specification of order
for installation of deployments.

Refs: #2176
Signed-off-by: Konstantin Yarovoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@svteb