feat: add @swc/[email protected] as a bug version, fallback to 0.1.12 #259
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "@swc/types": { | ||
| "0.1.16": { | ||
| "version": "0.1.12", | ||
| "reason": "https://github.com/swc-project/swc/issues/9753" | ||
| } | ||
| }, |
There was a problem hiding this comment.
💡 Codebase verification
The bug-version entry is correctly configured and the issue reference should be updated
The downgrade from v0.1.16 to v0.1.12 is correct as issue #9752 confirms that @swc/types versions >= 0.1.13 lack the index.js file, causing module resolution failures. However, the current reference points to issue #9753 which is about a different problem. The entry should reference issue #9752 instead.
- Update the issue reference in the reason field from #9753 to #9752
🔗 Analysis chain
LGTM! The bug-version entry is correctly configured.
The entry properly specifies the problematic version (0.1.16) and the fallback version (0.1.12), following the established pattern in the file.
Let's verify the referenced issue:
The referenced issue is not related to the missing index.js file
The issue #9753 in the swc-project/swc repository is about a different problem: "Cannot use import statement outside a module" in version 0.1.16. This doesn't match the stated rationale for downgrading to v0.1.12 (missing index.js file).
Let's verify if there are any other relevant issues:
Let's check the content of issue #9752 as it seems more relevant:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the issue exists and is related to the missing index.js
# Check if the issue exists and get its details
gh issue view 9753 --repo swc-project/swc
Length of output: 1381
Script:
#!/bin/bash
# Search for issues mentioning index.js and @swc/types
gh search issues "index.js @swc/types" --repo swc-project/swc --limit 5
# Also check if the package.json has any comments or related configuration
rg -A 2 -B 2 "@swc/types" package.json
Length of output: 344
Script:
#!/bin/bash
# Get details of the more relevant issue
gh issue view 9752 --repo swc-project/swc
Length of output: 1831
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
Branches 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
[skip ci] ## [1.105.0](v1.104.0...v1.105.0) (2024-11-21) ### Features * add @swc/[email protected] as a bug version, fallback to 0.1.12 ([#259](#259)) ([419dee3](419dee3))
@swc/[email protected]
has no index.js, 是一个非兼容性改动, 降级到 0.1.12
同步雨燕改动内容
Summary by CodeRabbit
@swc/typespackage with version0.1.16.