Merge pull request kubernetes-sigs#4185 from richardcase/make_maintai…

…ners_list

fix: getting maintainers fails

Makefile

@@ -80,7 +80,6 @@ USER_FORK ?= $(shell git config --get remote.origin.url | cut -d/ -f4) # only wo
 ifeq ($(USER_FORK),)
 USER_FORK := $(shell git config --get remote.origin.url | cut -d: -f2 | cut -d/ -f1) # for [email protected]:<username>/cluster-api.git style URLs
 endif
-IMAGE_REVIEWERS ?= $(shell ./hack/get-project-maintainers.sh ${YQ})
 
 # Release variables
 
@@ -579,6 +578,7 @@ release-changelog: $(GH) ## Generates release notes using Github release notes.
 
 .PHONY: promote-images
 promote-images: $(KPROMO) $(YQ)
+	IMAGE_REVIEWERS="$(shell ./hack/get-project-maintainers.sh ${YQ})"
 	$(KPROMO) pr --project cluster-api-provider-aws --tag $(RELEASE_TAG) --reviewers "$(IMAGE_REVIEWERS)" --fork $(USER_FORK) --image cluster-api-aws-controller
 
 .PHONY: release-binaries

hack/tools/Makefile

@@ -156,24 +156,14 @@ $(PLANTUML): plantuml.Dockerfile ../../versions.mk
 	touch $@
 
 KPROMO_BIN := kpromo
-KPROMO :=  $(abspath $(BIN_DIR)/$(KPROMO_BIN)-$(KPROMO_VER))
-KPROMO_PKG := sigs.k8s.io/promo-tools/v3/cmd/kpromo
-
-.PHONY: $(KPROMO_BIN)
-$(KPROMO_BIN): $(KPROMO) ## Build a local copy of kpromo
-
+KPROMO :=  $(BIN_DIR)/$(KPROMO_BIN)
 $(KPROMO):
-	GOBIN=$(BIN_DIR_ABS) $(GO_INSTALL) $(KPROMO_PKG) $(KPROMO_BIN) ${KPROMO_VERSION}
+	CGO_ENABLED=0 go build -o $@ sigs.k8s.io/promo-tools/v3/cmd/kpromo
 
 YQ_BIN := yq
-YQ :=  $(abspath $(BIN_DIR)/$(YQ_BIN)-$(YQ_VERSION))
-YQ_PKG := github.com/mikefarah/yq/v4
-
-.PHONY: $(YQ_BIN)
-$(YQ_BIN): $(YQ) ## Build a local copy of yq
-
+YQ :=  $(BIN_DIR)/$(YQ_BIN)
 $(YQ):
-	GOBIN=$(BIN_DIR_ABS) $(GO_INSTALL) $(YQ_PKG) $(YQ_BIN) ${YQ_VERSION}
+	CGO_ENABLED=0 go build -tags=tools -o $@ github.com/mikefarah/yq/v4
 
 ## ------------------------------------------------------------------------------------------------
 ## AWS Session Manager Plugin Installation. Currently support Linux and MacOS AMD64 architectures.