Add Software Supply Chain Best Practices v2 markdown #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tag-security ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@mnm678 To what extent do you want to resolve the linter findings before merging this? No hard opinions here - might be a few spelling items worth review. |
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
jkjell
reviewed
Oct 31, 2024
| Authors: Original White Paper authors, Marina Moore, Michael Lieberman, John Kjell, James Carnegie, Ben Cotton | ||
| Reviewers: | ||
|
|
||
| # Scope: {#scope:} |
There was a problem hiding this comment.
It looks like GitHub auto-generates this heading ids: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#section-links.
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
|
The remaining link error is a link to the file added in this pr, which should work once this is merged. And the remaining linter errors are for duplicate headings, which I disagree with (I actually think it's more clear to have a consistent document structure). Which means this is ready for review! |
|
I made this PR for the linter config which should resolve those. I agree that this should be allowed. #1397 |
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
brandtkeller
reviewed
Nov 6, 2024
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandt Keller <[email protected]> Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
|
Thanks @brandtkeller! Feedback applied |
brandtkeller
requested changes
Nov 6, 2024
community/working-groups/supply-chain-security/suply-chain-security-paper-v2/SSCBPv2.md
Outdated
Show resolved
Hide resolved
…urity-paper-v2/SSCBPv2.md Co-authored-by: Brandt Keller <[email protected]> Signed-off-by: Marina Moore <[email protected]>
Signed-off-by: Marina Moore <[email protected]>
brandtkeller
approved these changes
Nov 8, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Software Supply Chain working group has been working on an update to the Software Supply Chain Best Practices Paper. This is the markdown version of the document we have been working on.