Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wide option for badges, modularise badge rendering and avoid badge gaps #855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milanlakhani
Copy link
Contributor

@milanlakhani milanlakhani commented Nov 15, 2022

This ensures that there are no gaps when some badges on the left handside of the dialog box aren't used, by only allocating a div when the badge is in use.

This also adds a boolean setting, wide_badges, that can allow the badges to be positioned one on top of the other rather than in side by side pairs. This can be especially useful when a badge contains a lot of text.

If wide_badges is not set, it is assumed to be false.

The placement of the wide_badges config in settings.yml is as follows:

big_picture:
  main:
    wide_badges: true
    ...

CC @michaelmoss @awright @GeriG966 @danielsilverstone-ct @abhirampataru

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for landscapeapp ready!

Name Link
🔨 Latest commit ff7be34
🔍 Latest deploy log https://app.netlify.com/sites/landscapeapp/deploys/637412b6ef302b000863bf83
😎 Deploy Preview https://deploy-preview-855--landscapeapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@milanlakhani milanlakhani changed the title Add wide option for badges, modularise tag rendering and avoid tag gaps Add wide option for badges, modularise badge rendering and avoid badge gaps Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant