Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fields to include labelled hyperlinks and be split into sections #851

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

milanlakhani
Copy link
Contributor

@milanlakhani milanlakhani commented Nov 15, 2022

This enhances the look of fields in the item dialog boxes in two ways - enabling labelled hyperlinks and adding sections.

The labelled hyperlinks change allows extra fields in landscape.yml to have text values that link to a url that is not the same as the text. To add a labelled hyperlink, the syntax to use is <label>(hyperlink) (so same as markdown syntax except <> instead of [] )

The sections change adds an optional config in settings.yml, which can put the 'extra' fields in an item's dialog box into sections to improve the appearance.

Needless to

This is what the item detail box looks like with and without sections:
Without:
Screenshot 2022-08-04 at 14 37 03

With:
Screenshot 2022-08-04 at 15 34 17

The placement of the optional sections config in settings.yml is as follows:

big_picture:
  main:
    sections:
      - name: Section1 name
        children:
           - Key1 name in section
           - Key2 name in section
      - name : Section2 name
        children:
          ...

CC @michaelmoss @awright @GeriG966 @danielsilverstone-ct @abhi0469

When there is a 'sections' field in settings.yml, that 'sections'
object must contain all the keys that are in every item's 'extra'
section in landscape.yml. It need not contain keys that are not in
the 'extra' section.

Signed-off-by: Milan Lakhani <[email protected]>
To add a labelled hyperlink in one of your landscape yaml fields,
use <label>(hyperlink) , so same as markdown syntax except <>
instead of [] .

Signed-off-by: Milan Lakhani <[email protected]>
@milanlakhani milanlakhani changed the title Allow fields to include labelled hyperlinks and be put in sections Allow fields to include labelled hyperlinks and be split into sections Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for landscapeapp ready!

Name Link
🔨 Latest commit 9eaf377
🔍 Latest deploy log https://app.netlify.com/sites/landscapeapp/deploys/63740c76c137f80008ab294e
😎 Deploy Preview https://deploy-preview-851--landscapeapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@milanlakhani
Copy link
Contributor Author

Hi @AndreyKozlov1984 , I'm back from my holiday now, hope you are well. Feel free to let me know any improvements that I can make if it would help :)

@AndreyKozlov1984
Copy link
Contributor

@milanlakhani That is too much change, and it requires serious changes in the format. Ideally the format should be same as before, let me think a bit what we can afford

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants