-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability for custom CSS from user side #839
base: master
Are you sure you want to change the base?
Conversation
6fd552e
to
023b0c8
Compare
✅ Deploy Preview for landscapeapp ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for landscapeapp failed.
|
I want to get a better solution, the list of options will grow too much with this approach, instead I would prefer something like a |
Works for me, I will do a patch with a |
023b0c8
to
76d09e2
Compare
Hi @AndreyKozlov1984 I think and have tested that this now has the desired effect? Also maybe you should consider merging #836 when you get a chance - it's a bugfix that allows landscapes to be run without a crunchbase key, which has been pivotal for us to test our changes on different landscapes. |
@milanlakhani we don't need crunchbase key at this moment, because you can just use |
9df43a8
to
bec6d58
Compare
This flag in the global section of settings.yml allows landscapes to have custom CSS properties set. Signed-off-by: Milan Lakhani <[email protected]>
bec6d58
to
20abf5d
Compare
@AndreyKozlov1984 just to prompt you, this feature is now available as you requested it ;) and description updated |
This adds an optional config
extra_css
insettings.yml
, which allows extra lines of css to be appended to the end ofsrc/styles.css
, from the user end. This is useful because people may being using the landscape in different contexts - eg for Bloomberg, not every filter is applicable so we hide some of them.The
extra_css
config can be included insettings.yml
in theglobal
section. Below is an example of how this is used for having a selection of filters to not show on the left side:This is what the home page looks like with and without filters disabled, notice the difference in filters available on the left hand side:
Without any filters disabled:
With some filters disabled:
Of course this is just one example of how
extra_css
can be used.CC @michaelmoss @awright @danielsilverstone-ct @GeriG966 @abhi0469