Use PageFind for search #3008
Merged
Use PageFind for search #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Chris Abraham <[email protected]>
cjyabraham
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
10 tasks
jihoon-seo
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
LGTM!
One thing that I want to mention is that
- Currently, it seems that the Bengali, French, and Spanish versions of
search.mdfile exist inmainbranch.
- The search feature for e.g., Korean is not working, since there is no Korean version of
search.mdfile.
(e.g., https://deploy-preview-3008--cncfglossary.netlify.app/ko/search/?q=kubernetes show 404 Not Found.) - To make the search feature working for all languages, each L10n team should localize
search.mdfile and apply it tomainbranch.
jihoon-seo
added
the
maintainers
Signed-off-by: Chris Abraham <[email protected]>
cjyabraham
requested review from
tico88612,
ydFu,
hwchiu,
johnlinp,
hanyuancheung,
Jacob953,
Rocksnake,
Submarinee,
Saim-Safdar,
waleed318,
aliok,
halil-bugol,
rwxdash,
eminalemdar and
edsoncelio
as code owners
cjyabraham
requested review from
MrErlison,
yunkon-kim,
inductor,
naonishijima,
kaitoii11,
yuichi-nakamura,
Okabe-Junya,
fsbaraglia,
ugho16,
annalisag-spark,
sistella,
Garima-Negi,
jayesh-srivastava,
abhay-raj19,
aj11anuj,
justankiit,
bishal7679,
DaveVentura,
CathPag and
bcubk
as code owners
|
Thanks @jihoon-seo , I've dropped in search.md files in each of the translation directories ready to be translated. At least now they won't get a 404 if they try and search. |
bishal7679
approved these changes
Mar 25, 2024
…alink of the search Signed-off-by: Chris Abraham <[email protected]>
yes |
|
LGTM! Thanks @cjyabraham I tested that the functionality works well.
|
seokho-son
approved these changes
Mar 25, 2024
|
Let me merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From cncf/cncf.io#836:
Google Custom Search doesn't seem to produce very good search results on small sites. It'd be better to remove our reliance on Google as well. Instead we can use PageFind, which is an open source local search for static sites.
Current issues with GCS on the subsites:
Please test this to see if the search results are useful, complete and that it handles multiple languages effectively.