feat: container image build ci for push image to github registry #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
reviewed
Mar 14, 2022
| branches: [ ] | ||
|
|
||
| env: | ||
| # Use docker.io for Docker Hub if empty |
There was a problem hiding this comment.
Did you mean use "ghcr.io" for the registry if empty? The comment doesn't match the default value.
|
The build error looks to be unrelated to your change, I'm betting it's because of an old go version. I'll take a look. |
Rajpratik71
force-pushed
the
feat-ghcr-image-build-upload-support
branch
from
2c16436
to
90f1309
Compare
|
@carolynvs Please review , build is passing now |
Rajpratik71
force-pushed
the
feat-ghcr-image-build-upload-support
branch
from
90f1309
to
6aa724d
Compare
|
Hi @radu-matei @silvin-lubecki requesting review |
Use GitHub CI to build the latest Container image on git push and store container image on GitHub registry Signed-off-by: Pratik Raj <[email protected]>
Rajpratik71
force-pushed
the
feat-ghcr-image-build-upload-support
branch
from
6aa724d
to
775f744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub CI to build the latest Container image on git push and store container image on GitHub registry
Signed-off-by: Pratik Raj [email protected]