Merge pull request rdkcentral#5276 from sborushevsky/RDKTV-30706

RDKTV-30706 : Added check if that is the file to fileExists()
cmuhammedrafi · May 13, 2024 · 3b5f4ef · 3b5f4ef
2 parents b4a44b4 + 29039af
commit 3b5f4ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/helpers/UtilsfileExists.h b/helpers/UtilsfileExists.h
@@ -6,6 +6,6 @@ namespace Utils {
 inline bool fileExists(const char* pFileName)
 {
     struct stat fileStat;
-    return 0 == stat(pFileName, &fileStat);
+    return 0 == stat(pFileName, &fileStat) && S_IFREG == (fileStat.st_mode & S_IFMT);
 }
 }
diff --git a/helpers/cSettings.h b/helpers/cSettings.h
@@ -195,8 +195,7 @@ class cSettings {
         }
         fstream ifile(filename, ios::in);
         if (ifile) {
-            while (!ifile.eof()) {
-                std::getline(ifile, content);
+            while (std::getline(ifile, content)) {
                 size_t pos = content.find_last_of("=");
                 if (std::string::npos != pos) {
                     data[(content.substr(0, pos).c_str())] = content.substr(pos + 1, std::string::npos);