Separate email file and user + password prompt #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The comments on mail.py should be edited to be consistent with the changes that have been made to the file. |
Oh you're right. Sorry about that! I'll fix that right away. |
aspyrx
requested changes
Jan 23, 2019
There was a problem hiding this comment.
Sorry, this took me a while to get to - been quite busy.
.DS_Storefiles and other cruft should never be committed! Add it to your global Git ignore file.- See other comments for notes.
mail.py
Outdated
| EMAIL_ADDRESS = input("Please type your email address username: ") | ||
| PASSWORD = input("Please type your email password: ") | ||
|
|
||
| EMAIL_DATA_FILEPATH = 'Email_Text_Files/email_data.txt' |
There was a problem hiding this comment.
File paths should be consistently named; camelCase or kebab-case is probably preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subject, english email, and japanese email in the email_data.txt file are broken up by the "*" character
use input() for username and password input