Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes inconsistences with pronouns in emotes #688

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

The32bitguy
Copy link
Contributor

@The32bitguy The32bitguy commented Jan 20, 2025

About the pull request

Stops the words "their/them/they", and other pronouns being swapped in the chatlog with the equivalent of the character's pronoun/gender when they do a /me.
Langchat now shows the characters pronouns for predefined emotes, same as the chatlog.

Explain why it's good for the game

It is unnecessary and confusing to not be able to use these words in an emote, and to have your emote subtly changed.

Testing Photographs and Procedure

CUSTOM EMOTE TEXT:
image
BEFORE:
Screenshot 2025-01-20 020413
image
AFTER:
Screenshot 2025-01-20 020413
image

PREDEFINDED EMOTE TEXT:
image

BEFORE:
image
image

AFTER:
image
image

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Pronouns are no longer force replaced in the chatlog output of a Me verb with the character's equivalent. No more "their" --> "her".
fix: Overhead chat now uses the character's pronouns for predefined emotes, like the chatlog already does.
/:cl:

@The32bitguy The32bitguy changed the title Stop "their/them/they" being force replaced in the Me verb Stop pronouns being force replaced in the Me verb Jan 20, 2025
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way to do this. This also affects all emotes (*shakehead for example) that are not manually entered. Additionally, just remove code instead of commenting it out.

@Zonespace27 Zonespace27 marked this pull request as draft January 20, 2025 02:48
@The32bitguy The32bitguy marked this pull request as ready for review January 20, 2025 03:45
@The32bitguy The32bitguy changed the title Stop pronouns being force replaced in the Me verb Fixes inconsistences with pronouns in emotes Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants