Allows Chances Claim [Forecon] to be selected #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DexterDude
reviewed
Dec 21, 2024
| @@ -0,0 +1,38 @@ | |||
| { | |||
| "map_name": "LV-522 Chance's Claim Forecon", | |||
There was a problem hiding this comment.
Just leave this without the forecon as I believe it shows up as the map name in game and I think that'd be a bit awkward.
There was a problem hiding this comment.
But that would result in 2 maps named Lv-522 Chance's Claim, and afaik the map picker uses the map name, resulting in 2 names, is there any way you know to avoid this?
cm13-github
added a commit
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
When #550 was merged, it didn't actually add anything other than the map file for chances claim forecon variation, meaning that the only way to select it was to override the map (very inconvenient).
Also changes a bit of text for FORECONLESS chance's so that it doesn't mention forecon, only the colony
Explain why it's good for the game
GMs should be able to pick forecon chances claim without needing to manually override the map
Testing Photographs and Procedure
Changelog
🆑
fix: Chances Claim [Forecon] can now be properly selected by GMs
/:cl: