Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes PMC and RMC Smartguns use 10x28. Brought up damage to standard. #601

Merged
merged 6 commits into from
Dec 23, 2024

Conversation

private-tristan
Copy link
Contributor

@private-tristan private-tristan commented Dec 12, 2024

About the pull request

PMC smartgun:
is now a reskin of the marine smartgun with PMC IFF. Uses regular drums.

Terminator Smartgun:
precise damage from 40 to 60 (Regular SG does 55)
AP damage from 30 to 45 (Regular AP does 40)
still irradiates and inflicts agony on hit

RMC Smartgun:
Damage from 30 to 50 (Regular SG does 55)
AP from 20 to 30 (Regular AP does 40)

Explain why it's good for the game

#376 only changed the regular smartgun ammo, meaning that PMC's SG (Which used to have more damage + irradiation) now did 15 less damage per shot than a regular old SG, which is a bit strange seeing how PMCs are meant to have a better kit than marines.

And I did RMC too because they've got high tech or whatever, smartgun goes pew pew

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: PMC and RMC smartguns now use irradiated/holotarget 10x28mm instead of snowflake SG bullets, meaning damage has also been increased to standard levels.
balance: Terminator smartguns now also use irradiated 10x28mm, and do more damage per shot.
fix: PMC smartgunner loadout now properly spawns with its imager, allowing IFF to be used.
/:cl:

@DexterDude
Copy link
Contributor

DexterDude commented Dec 12, 2024

SGs are already a bit powerful as is and with PMCs becoming a platoon I dont think they need to be stronger, I would just nuke dirty rounds for everything except the whiteout SG.

However, bringing the PMC/TWE SG rounds up to par with normal marine SG rounds is fine.

@Zonespace27
Copy link
Contributor

I agree with Verbs on this one. SGs are already ludicrously strong and we don't need these ones being stronger than the standard marine ones. Additionally, this will make Human AI PMC/RMC smartgunners even stronger, which is not a good idea.

@private-tristan private-tristan changed the title Makes PMC and RMC Smartguns use 10x28, buffs damage. Makes PMC and RMC Smartguns use 10x28. Brought up damage to standard. Dec 14, 2024
Copy link
Contributor

@DexterDude DexterDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also want to ensure that the belt has the proper ammo.

code/modules/projectiles/guns/smartgun.dm Outdated Show resolved Hide resolved
@private-tristan
Copy link
Contributor Author

PR ready. PMCs fire regular SG bullets, have regular SG drums. Terminator SGs have the better bullets.

Changed loadouts so that terminator gets dirty SG drums while regular SGs get normal drums.

@AndroBetel AndroBetel merged commit 207fdca into cmss13-devs:master Dec 23, 2024
37 checks passed
cm13-github added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants