Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Dogtags removable on death immediately #514

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

GriffinMan4455
Copy link
Contributor

@GriffinMan4455 GriffinMan4455 commented Oct 22, 2024

About the pull request

Lets marines take the identifier off a dead buddie's tags immediately on their demise

Tested, works fine

Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. -->

Explain why it's good for the game

Stinky PvP thing where you can only remove them after five minutes since they have like revives and stuff but we don't have that

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Dogtags removable after 30 seconds
/:cl:

DexterDude
DexterDude previously approved these changes Oct 22, 2024
Ah, yeah I meant to change this back after finding the part of human_defines.dm but must've discarded the changes back as part of a different commit, whoops

Co-authored-by: Doubleumc <[email protected]>
GriffinMan4455 and others added 4 commits October 23, 2024 16:45
Oh! That works too, I mostly just did the 30 second check because I didn't want to potentially break (and thus have to fix) the stripping part, but so long as it works o7

Co-authored-by: Doubleumc <[email protected]>
@GriffinMan4455
Copy link
Contributor Author

You the goat UMC, everything works perfectly now! Tags are immediately grabbable on death o7

@GriffinMan4455 GriffinMan4455 changed the title Makes Dogtags removable after 30 seconds Makes Dogtags removable on death Oct 24, 2024
@GriffinMan4455 GriffinMan4455 changed the title Makes Dogtags removable on death Makes Dogtags removable on death immediately Oct 24, 2024
@Doubleumc Doubleumc merged commit 75b877f into cmss13-devs:master Oct 24, 2024
39 checks passed
cm13-github added a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants