Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Support Menu GAU and Laser fixes #511

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

GriffinMan4455
Copy link
Contributor

@GriffinMan4455 GriffinMan4455 commented Oct 19, 2024

About the pull request

Makes the GAU's and Laser in the GM Fire Support menu work again

Tested, they work fine now.
SO to Drathek, gave me a much better solution that also lets cause data work when fired by regular DS pilots

Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. -->

Explain why it's good for the game

GM tools should work 👍

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: GAU and Laser in FS Menu work again yippeee
/:cl:

@github-actions github-actions bot added the fix label Oct 19, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause data is very flexible what you can give it. Simply handle the fired from location sometimes not being provided e.g. fired_from?.name rather than remove all cause data functionality.

@Drulikar Drulikar marked this pull request as draft October 19, 2024 17:02
@GriffinMan4455
Copy link
Contributor Author

It's like I said in the discord, I did it this way because I don't know how to do what you're asking, and it's better to have features GM's use work fine rather than have cause data (something that's not...really useful on PvE anyways?)
That was my reasoning at least, and none of the GM's took issue with it when I said that was what I was doing /shrug

@GriffinMan4455 GriffinMan4455 marked this pull request as ready for review October 20, 2024 04:44
@GriffinMan4455
Copy link
Contributor Author

Oh? Hold off on that review then lemee see what I did

…ive a cause when you die to them, felt odd that specifically these three would
@Drulikar Drulikar merged commit 882842a into cmss13-devs:master Oct 21, 2024
36 checks passed
cm13-github added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants