-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire Support Menu GAU and Laser fixes #511
Conversation
…fire suport menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cause data is very flexible what you can give it. Simply handle the fired from location sometimes not being provided e.g. fired_from?.name
rather than remove all cause data functionality.
It's like I said in the discord, I did it this way because I don't know how to do what you're asking, and it's better to have features GM's use work fine rather than have cause data (something that's not...really useful on PvE anyways?) |
… in the fire suport menu." This reverts commit a820a4f.
Oh? Hold off on that review then lemee see what I did |
…ive a cause when you die to them, felt odd that specifically these three would
About the pull request
Makes the GAU's and Laser in the GM Fire Support menu work again
Tested, they work fine now.
SO to Drathek, gave me a much better solution that also lets cause data work when fired by regular DS pilots
Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. -->
Explain why it's good for the game
GM tools should work 👍
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
fix: GAU and Laser in FS Menu work again yippeee
/:cl: