Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brings back PltCo medal awarding #493

Merged

Conversation

BonniePandora
Copy link
Contributor

About the pull request

Fixes something the upstream merge messed up amidst the torrent of changes, allowing the lowly LT to once again issue medals for their platoon.

Explain why it's good for the game

Is this bit even needed? We almost never have command personnel above Captain rank present, so limiting medals being issued out to those at O4 paygrade and above is inane.

Testing Photographs and Procedure

Compiled fine with no errors

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Platoon Commanders can once again issue medals to those under their command
/:cl:

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is an issue. Will merge as soon as the feedback is addressed.

code/datums/medal_awards.dm Outdated Show resolved Hide resolved
code/datums/medal_awards.dm Show resolved Hide resolved
code/datums/paygrades/paygrade.dm Outdated Show resolved Hide resolved
@Doubleumc Doubleumc merged commit 278bad6 into cmss13-devs:master Oct 5, 2024
36 checks passed
cm13-github added a commit that referenced this pull request Oct 5, 2024
@BonniePandora BonniePandora deleted the Medal-Awarding-unfuckening branch December 23, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants