This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
support for other network domains #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the default network prefix from host names
…ameFromContext() (instead of hardwired string literals)
… with value obtained from ContextHelper.getNetworkSuffix()
…e configured properties
…sure proper testing
…lication wide network domain
…application wide network domain
…for application wide network domain
andreh12
changed the title
|
please have a look, should be complete now (tests work). After this pull request we only have
Note that f093975 introduced an additional mandatory configuration parameter |
|
The produced snapshots for 904 look fine. Thanks for implementing this. Edit: The first couple of produced snapshots after starting the aggregator seem to be missing data. Edit2: Nevermind. It was the first couple of snapshots after creating the configuration that contain invalid data (probably due to missing flashlist information). |
|
This appears to happen only when the LV0 is not yet initialized or being destroyed. See cmsdaq/daqview-react#39 for an example. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still work in progress, will fix #104