Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interface to retrieve subsets of histograms from a histogram collection #39

Open
benkrikler opened this issue Jun 7, 2017 · 1 comment
Open

Improve interface to retrieve subsets of histograms from a histogram collection #39

benkrikler opened this issue Jun 7, 2017 · 1 comment
Milestone
version 0.8

Comments

@benkrikler
Copy link
Contributor

At the moment the interface to obtain a particular set of histograms from a histogram collection is a little bit clumsy. It would be nice to improve this, using something like array slices or otherwise, but this needs a bit of thought.

For example, it would be nice to make the sorts of things done here: cmsl1t/plotting/efficiency.py#L64-L69 and here: cmsl1t/plotting/efficiency.py#L72-L80

I think this should only really need changes to the HistCollection and the binning.Base classes.
@kreczko kreczko added this to the Alpha future milestone Jun 7, 2017
@kreczko kreczko modified the milestones: future release, version 0.8 May 8, 2018
@kreczko kreczko mentioned this issue May 31, 2019
Open
@kreczko
Copy link
Member

kreczko commented Jul 18, 2019

That should be now implemented in #173

@kreczko kreczko mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
version 0.8
Development

No branches or pull requests
2 participants
@kreczko @benkrikler