-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New histogram collection: VectorizedHistCollection #173
Conversation
… name is given (to avoid name clashes)
6192e65
to
e643ec9
Compare
This pull request fixes 1 alert when merging e643ec9 into ead9128 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 114f53c into ead9128 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 09178f4 into ead9128 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 51d44d3 into ead9128 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of questions and comments for you Luke, hopefully as you wanted!
…sing innerBins for innerHist
ok, @benkrikler, that should be that for now. I am addressing the jetMet_analyzer in a separate branch |
This pull request fixes 1 alert when merging cb28ed4 into ead9128 - view on LGTM.com fixed alerts:
|
Fixes #39, #171
Introduces
VectorizedHistCollection
that adds two things w.r.t.BaseHistCollection
:Accessing
collection[pileup]
withpileup = [1, 12, 1, 50]
will automatically return the histograms for the correct pileup bins (not values). This part is generalized through theVectorizedBinProxy
.Filling histograms can be done with either
scalar
,numpy.ndarray
orawkward.JaggedArray
.VectorizedHistCollection
also introduces some experimental functionality, e.g.execute_before_write
.The
execute_before_write
parameter can be used to schedule function calls before the collection is written to disk. E.g. this could replace the EfficiencyCollection's_calculateEfficiencies
call (i.e. a step towards the generalization of histogram collections). This part is generalized through theVectorizedHistProxy
.Example
Further work needed