BX synchronization #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from merge_stream module
aehart
reviewed
Oct 22, 2024
aehart
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
This looks good to me. I'll hold off merging though until cms-L1TK/firmware-hls#349 is settled, in case any additional changes are needed here.
|
merging since firmware_hls #349 is settled, and just needs updated submodule. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to VHDL top file generation to allow tf_merge_streamer modules to receive TP_bx_vld and pass the delayed TP_bx_vld to the top-level output.
Due to lack of familiarity with the VHDL generation scripts, the way the delayed TP_bx_vld (TP_bx_vld_merged) is passed from the first tf_merge_streamer module to the output is rather hacky. Any suggestions as to how to fix this are welcome.