-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New track builder and write_mem cleanup #352
Draft
aryd
wants to merge
15
commits into
master
Choose a base branch
from
NewTrackBuilder
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function setWriteBX has been added to all three MemoryTemplate*.h classes, but it seems never to be called? |
This is part of aligning the test benches with how this implemented for the integrated project. In the integrated project we have these memories implemented in vhdl. The ‘framework’ takes care of managing which BX is being processed. So when a (HLS) processing module writes to a memory it does not specify the BX. However, the interface - for historical reasons - included the BX. So in this cleanup I removed this argument. The argument was used in the simulation implementation and I now changed this so that you set the BX that is being written through this setWriteBX method. It is called in all the test benches.
Hope this helps.
-Anders
Anders Ryd
***@***.******@***.***>
On Dec 11, 2024, at 8:45 PM, Ian Tomalin ***@***.******@***.***>> wrote:
Function setWriteBX has been added to all three MemoryTemplate*.h classes, but it seems never to be called?
—
Reply to this email directly, view it on GitHub<#352 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABI4LTJGNQTWMMIPBJ2CLQD2FCI4LAVCNFSM6AAAAABTKXNKTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZWHE3DIOJRGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
…s around HLS limitations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update has the combined TrackBuilder module and cleanup of the write_mem methods.