-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First FPGA with TPAR/AS merging #338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aehart
reviewed
May 23, 2024
jasonfan393
force-pushed
the
TF_TPAR_AS_MERGE
branch
from
June 3, 2024 18:14
bd51be5
to
b7aa74f
Compare
jasonfan393
force-pushed
the
TF_TPAR_AS_MERGE
branch
from
June 25, 2024 16:30
967e809
to
1b6dd4c
Compare
aehart
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to prepare for changes to sectorprocessor on FPGA 1 that enables the merging and streaming of TPAR and AS words to FPGA2. Interface of sector processor is changed from a read of BRAMs containing those words to a FIFO-like output stream.
Opening as a draft to check CI and work out merging.
some bugs in simulation right now, AllStubs not streaming properly and some extra truncation.