-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SW/FW synchronization #309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aehart
force-pushed
the
fw_synch_231205
branch
from
December 15, 2023 18:21
addd2bf
to
7079b81
Compare
… the track paremeter memory
aehart
force-pushed
the
fw_synch_231205
branch
from
December 20, 2023 13:30
7079b81
to
1905be8
Compare
aryd
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this is removal of obsolete code - the other changes looked fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes the FW with the SW emulation at fw_synch_231205.
The opportunity is also taken to purge the repo of all non-combined modules that are now irrelevant and to add phi regions to the seed stub indices in the TPAR and TF memory classes.
Ideally, we should merge #304 first (DONE!), so that the HEAD of the master branch can be tagged as the last working version with non-combined modules before merging this PR.