Fix of typo in TrackletEngineUnit #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry about the typo - this is definitely the intended code. No idea how this produced sensible results for L3L4/L2L3. CSIM and CSYNTH are working fine. Will double check implementation resource numbers and such - but this should be fine |
jasonfan393
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a little too trigger-happy with the merge button, and missed a typo with the parentheses that was introduced in #303. This PR simply fixes the typo.
@jasonfan393 Could you please check this out and approve it if it looks OK? Hopefully everything still looks OK for the TPs.