Fixed disk bits #299
Fixed disk bits #299
Conversation
My test have finished and I see full agreement for all disk and barrel layers for PHI A - PHI F (using the same numbers as the |
|
The CI seems to be having an issue downloading the artifacts from a previous step Runtime platform arch=amd64 os=linux pid=3516 revision=8ec04662 version=16.3.0
ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.ch id=[33](https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/jobs/33431685#L33)431684 responseStatus=200 OK token=64_v1ajV
WARNING: Retrying... error=invalid argument
ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.ch id=33431684 responseStatus=200 OK token=64_v1ajV
WARNING: Retrying... error=invalid argument
ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.ch id=3[34](https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/jobs/33431685#L34)31684 responseStatus=200 OK token=64_v1ajV
FATAL: invalid argument
Cleaning up project directory and file based variables
00:00
ERROR: Job failed: exit status 1Hopefully this is a transient issue. I'll retry the CI later. |
The CI is running now. Once it finishes, we should be able to merge this PR. |
I am seeing some strange errors in the CI for Comparing TB results ./dataOut/FM_L1L2_L3PHIA.txt to ref. file ./MemPrints/Matches/FullMatches_FM_L1L2_L3PHIA_04.dat ...
Doing event 0/100 ...
Doing event 1/100 ...
Doing event 2/100 ...
Doing event 3/100 ...
Doing event 4/100 ...
Doing event 5/100 ...
Doing event 6/100 ...
Doing event 7/100 ...
Doing event 8/100 ...
Doing event 9/100 ...
Doing event 10/100 ...
Doing event 11/100 ...
Doing event 12/100 ...
Doing event 13/100 ...
Doing event 14/100 ...
Event 14 does not exist in the comparison data!
The number of entries in the comparison data doesn't match the number of entries in the reference data for event 14!
reference=1 comparison=0@aryd @aehart do either of you have any ideas on what could cause this? Is it related to my new test vectors? |
|
Do you have access to these files:
./dataOut/FM_L1L2_L3PHIA.txt to ref. file ./MemPrints/Matches/FullMatches_FM_L1L2_L3PHIA_04.dat
and can check what went wrong?
…-Anders
Anders Ryd
***@***.******@***.***>
On Oct 26, 2023, at 6:25 PM, Brent R. Yates ***@***.******@***.***>> wrote:
The CI seems to be having an issue downloading the artifacts from a previous step
Runtime platform arch=amd64 os=linux pid=3516 revision=8ec04662 version=16.3.0
ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.ch<http://gitlab.cern.ch/> id=[33](https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/jobs/33431685#L33)431684 responseStatus=200 OK token=64_v1ajV
WARNING: Retrying... error=invalid argument
ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.ch<http://gitlab.cern.ch/> id=33431684 responseStatus=200 OK token=64_v1ajV
WARNING: Retrying... error=invalid argument
ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.ch<http://gitlab.cern.ch/> id=3[34](https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/jobs/33431685#L34)31684 responseStatus=200 OK token=64_v1ajV
FATAL: invalid argument
Cleaning up project directory and file based variables
00:00
ERROR: Job failed: exit status 1
Hopefully this is a transient issue. I'll retry the CI later.
The CI is running now. Once it finishes, we should be able to merge this PR.
I am seeing some strange errors in the CI for topReducedCombined-check-results
Comparing TB results ./dataOut/FM_L1L2_L3PHIA.txt to ref. file ./MemPrints/Matches/FullMatches_FM_L1L2_L3PHIA_04.dat ...
Doing event 0/100 ...
Doing event 1/100 ...
Doing event 2/100 ...
Doing event 3/100 ...
Doing event 4/100 ...
Doing event 5/100 ...
Doing event 6/100 ...
Doing event 7/100 ...
Doing event 8/100 ...
Doing event 9/100 ...
Doing event 10/100 ...
Doing event 11/100 ...
Doing event 12/100 ...
Doing event 13/100 ...
Doing event 14/100 ...
Event 14 does not exist in the comparison data!
The number of entries in the comparison data doesn't match the number of entries in the reference data for event 14!
reference=1 comparison=0
@aryd<https://github.com/aryd> @aehart<https://github.com/aehart> do either of you have any ideas on what could cause this? Is it related to my new test vectors?
—
Reply to this email directly, view it on GitHub<#299 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABI4LTMSHRBXGO7X2ZWJW7DYBKFH7AVCNFSM6AAAAAA6OHOODOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGQ2TAMRXHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I downloaded the CI artifacts. Here are the first 15 events: The 14th entry (zero indexed) is selected_rows = selected_columns.loc[selected_columns['BX'] == ievent] |
@aryd looking at some other CI logs, there have been similar issues for a while. The number of mismatches changes, so I'm not sure if it's just an issue on the CI machine. I don't think this PR is specifically causing it, so I think we should merge now. |
|
I’m OK with merging the PR.
-Anders
Anders Ryd
***@***.******@***.***>
On Oct 26, 2023, at 9:17 PM, Brent R. Yates ***@***.******@***.***>> wrote:
Do you have access to these files: ./dataOut/FM_L1L2_L3PHIA.txt to ref. file ./MemPrints/Matches/FullMatches_FM_L1L2_L3PHIA_04.dat and can check what went wrong?
…<x-msg://766/#>
-Anders Anders Ryd @.***@***.*****> On Oct 26, 2023, at 6:25 PM, Brent R. Yates @.***@***.*****>> wrote: The CI seems to be having an issue downloading the artifacts from a previous step Runtime platform arch=amd64 os=linux pid=3516 revision=8ec04662 version=16.3.0 ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.chhttp://gitlab.cern.ch/<http://gitlab.cern.chhttp//gitlab.cern.ch/> id=33<https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/jobs/33431685#L33>431684 responseStatus=200 OK token=64_v1ajV WARNING: Retrying... error=invalid argument ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.chhttp://gitlab.cern.ch/<http://gitlab.cern.chhttp//gitlab.cern.ch/> id=33431684 responseStatus=200 OK token=64_v1ajV WARNING: Retrying... error=invalid argument ERROR: Downloading artifacts from coordinator... error error=unexpected EOF host=gitlab.cern.chhttp://gitlab.cern.ch/<http://gitlab.cern.chhttp//gitlab.cern.ch/> id=334<https://gitlab.cern.ch/cms-l1tk/firmware-hls/-/jobs/33431685#L34>31684 responseStatus=200 OK token=64_v1ajV FATAL: invalid argument Cleaning up project directory and file based variables 00:00 ERROR: Job failed: exit status 1 Hopefully this is a transient issue. I'll retry the CI later. The CI is running now. Once it finishes, we should be able to merge this PR. I am seeing some strange errors in the CI for topReducedCombined-check-results Comparing TB results ./dataOut/FM_L1L2_L3PHIA.txt to ref. file ./MemPrints/Matches/FullMatches_FM_L1L2_L3PHIA_04.dat ... Doing event 0/100 ... Doing event 1/100 ... Doing event 2/100 ... Doing event 3/100 ... Doing event 4/100 ... Doing event 5/100 ... Doing event 6/100 ... Doing event 7/100 ... Doing event 8/100 ... Doing event 9/100 ... Doing event 10/100 ... Doing event 11/100 ... Doing event 12/100 ... Doing event 13/100 ... Doing event 14/100 ... Event 14 does not exist in the comparison data! The number of entries in the comparison data doesn't match the number of entries in the reference data for event 14! reference=1 comparison=0 @arydhttps://github.com/aryd @aeharthttps://github.com/aehart do either of you have any ideas on what could cause this? Is it related to my new test vectors? — Reply to this email directly, view it on GitHub<#299 (comment)<#299 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI4LTMSHRBXGO7X2ZWJW7DYBKFH7AVCNFSM6AAAAAA6OHOODOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGQ2TAMRXHA. You are receiving this because you were mentioned.Message ID: @.***>
I downloaded the CI artifacts. Here are the first 15 events:
TIME (ns) BX ADDR DATA
4998 ns 8 0x00 0x0408001BFB000
5002 ns 8 0x01 0x040C001A101FD
10190 ns 20 0x00 0x042001EFFC004
10194 ns 20 0x01 0x042401EE04005
17094 ns 36 0x00 0x04080008081FC
20114 ns 43 0x80 0x0408070BF51FF
20122 ns 43 0x81 0x0410070BF81FC
20130 ns 43 0x82 0x0418070BFB006
20134 ns 43 0x83 0x041C070BFC003
20138 ns 43 0x84 0x0420070BFB1FF
20142 ns 43 0x85 0x0424070BFF005
20978 ns 45 0x80 0x040403FDF51FD
20982 ns 45 0x81 0x040803FDED1F6
20986 ns 45 0x82 0x040C03FDFA1FB
20998 ns 45 0x83 0x041801F6021FB
The 14th entry (zero indexed) is 0x041801F6021FB which I do have in my test vectors 0x03 0000010|0000110|0000000001|1111011|000000010000|111111011 0x041801F6021FB Maybe this isn't how it counts? I'm seeing calls to a panda dataframe in the comparison script, and it seems to be using the BX number as the event
selected_rows = selected_columns.loc[selected_columns['BX'] == ievent]
@aryd<https://github.com/aryd> looking at some other CI logs, there have been similar issues for a while. The number of mismatches changes, so I'm not sure if it's just an issue on the CI machine. I don't think this PR is specifically causing it, so I think we should merge now.
—
Reply to this email directly, view it on GitHub<#299 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABI4LTPY4P7YK76BXVNYU3LYBKZLVAVCNFSM6AAAAAA6OHOODOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRG42TONZYHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This PR fixes a bug in the MP tables for the disks (not enough bits) and updates the index value to match the recent emulation PR (cms-L1TK/cmssw#242). I'm running a full set of tests now, but so far I see full agreement with my latest test vectors (https://cernbox.cern.ch/s/8ADWsUnqUAPmI2m/download).