Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid order race conditions #8

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Avoid order race conditions #8

merged 10 commits into from
Dec 17, 2024

Conversation

cmin764
Copy link
Owner

@cmin764 cmin764 commented Nov 23, 2024

When making simultaneous payments (to trigger orders), we may risk allowing overselling due to the absence of a sync mechanism between checking the available stock on the moment of ordering and the stock deduction itself during a successful order.

@cmin764 cmin764 added enhancement New feature or request refactor Refactor code not behaviour labels Nov 23, 2024
@cmin764 cmin764 self-assigned this Nov 23, 2024
@cmin764 cmin764 marked this pull request as ready for review December 17, 2024 20:53
@cmin764 cmin764 merged commit 02e1bcd into main Dec 17, 2024
1 check passed
@cmin764 cmin764 deleted the feature/order-race-condition branch December 17, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Refactor code not behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant