Voice Chat support

[celguar]

🍰 Voice Chat

Info

• Adds Voice Chat handlers/manager to the core and a separate Voice Chat server that handles voice exchange

What is Voice Chat

• https://web.archive.org/web/20080913160710/http://www.worldofwarcraft.com/info/basics/voicechat.html

Core changes

• (Re)Connection to voice chat server
• Add most related opcode handlers
• Automatically create group/raid/bg channels server side
• Custom channel voice is enabled when someone with voice chat enabled joins it (found it here https://www.youtube.com/watch?v=h5oH4ER2cJ0)
• Group/Raid/BG leaders & channel owners can mute others in channel, though it doesn't persist if someone leaves channel e.g. relogs
• Can mute other players, works similar to ignore, but blocks only voice of that player. Ignoring other player blocks both chat and voice.

VoiceChat server

• Is a separate app that handles UDP voice packets from the game (basically just sends them unchanged to other active members of the voice channel)
• Is added using cmake FetchContent from here https://github.com/celguar/voicechat-server
• Is the one made by Ascent Team (specifically, by Burlex) back in 2007-08, just with couple opcodes added and CmakeLists.txt https://github.com/SkyFire/ascent_classic/tree/master/src/ascent-voicechat
• Can be on a separate host, but requires a TCP connection to world server and a UDP connection for users to connect. Ports are configurable
• Builds on Windows and Linux, but I think it doesn't support -c parameter for config file so probably uses current directory when you start it

Demonstration

• Test I did using cmangos-wotlk and 3.3.5, seems to work the same as 2.4.3 https://www.youtube.com/watch?v=_HfS_a79mco

Todo / Checklist

I don't expect this PR to be merged anytime soon, just made it because I did what I could at this point and want to share

• Might need to wait for realm/server manager implemenation by Cyberium, it should have a better AsyncConnector code with DNS support
• Maybe it's better to make our own c/c++ based VoiceChat server from scratch instead of using a modified Ascent Team one (though it builds/runs/works on both Windows and Linux, and I don't know how to do it so didn't consider it)
• SMSG_VOICE_ROSTER_UPDATE sends encryption key that I didn't try to figure out. So now it just remains uint8[16] and 0x00
• Most people I asked were interested in proximity voice chat, I didn't try to do it. If tbc+ server can force join player to a custom chat channel, maybe it's possible, but voice codec is proprietary and I don't know a way to alter the volume for a better distance effect, also voice chat is probably mono sound.

[al3xc1985]

wow, just WOW

[betayi]

amazing！

[killerwife]

I just want to make sure you know, me and cyberium talked about merging this and we kinda agree it should be merged, but it will require the attention of one of us. I do not want to make any promises, however once I am done processing my tbc data I gathered, I will look at it. (estimating 2-3 months from now)

Obviously if someone else picks it up and reviews/fixes any design issues, no problem there. I just kinda swamped myself with the whole wotlk going away.

[Lordron]

Client names are MemberGUID, NetworkId, Flags and for unk it's Priority

[celguar]

Please elaborate