-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD2-Part of the Shattrath Trainee event. #510
Draft
insunaa
wants to merge
13
commits into
cmangos:master
Choose a base branch
from
insunaa:shatt_recruits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insunaa
commented
Feb 19, 2022
Comment on lines
31
to
37
#include "AI/BaseAI/AIDefines.h" | ||
#include "AI/ScriptDevAI/ScriptDevAIMgr.h" | ||
#include "AI/ScriptDevAI/include/sc_common.h" | ||
#include "AI/ScriptDevAI/base/escort_ai.h" | ||
#include "AI/ScriptDevAI/include/sc_creature.h" | ||
#include "Entities/Creature.h" | ||
#include "Entities/Unit.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are as always added automatically by my IDE, I'll remove them on the final step for cleanup
insunaa
commented
Feb 19, 2022
insunaa
commented
Feb 19, 2022
killerwife
reviewed
Feb 19, 2022
killerwife
reviewed
Feb 19, 2022
@insunaa perhaps finish this or mark it not as draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This is the SD2-Part of the Shattrath Trainee event
How2Test
.tele Shattrath
Todo / Checklist