Wrap errors correctly #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orozery
force-pushed
the
nit
branch
2 times, most recently
from
3089e15 to
1ed787b
Compare
elevran
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
nit: this could belong in a different PR which can be merged first to allow other (currently failing) PR's to pass.
orozery
force-pushed
the
nit
branch
3 times, most recently
from
b4792da to
1417f80
Compare
This commit changes wrapped errors to use %w instead of %v. Signed-off-by: Or Ozeri <[email protected]>
This commit fixes some issues causing tests/k8s.sh to fail. Signed-off-by: Or Ozeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes wrapped errors to use %w instead of %v.