Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen fixups concerning dashes and jsr deps #17

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

danopia
Copy link
Member

@danopia danopia commented Oct 15, 2024

codegen output diff

Input CRD: https://github.com/zalando/postgres-operator/raw/refs/heads/master/charts/postgres-operator/crds/postgresqls.yaml

diff --git a/original/acid.zalan.do@v1/mod.ts b/fixed/acid.zalan.do@v1/mod.ts
index c0f09b6..fd641a4 100644
--- a/original/acid.zalan.do@v1/mod.ts
+++ b/fixed/acid.zalan.do@v1/mod.ts
@@ -3,7 +3,7 @@ export * from "./structs.ts";
 // Autogenerated API file for AcidZalanDoV1
 import * as c from "jsr:@cloudydeno/kubernetes-apis/common.ts";
 import * as operations from "jsr:@cloudydeno/kubernetes-apis/operations.ts";
-import * as MetaV1 from "jsr:@cloudydeno/kubernetes-apis/builtin/meta@v1/structs.ts";
+import * as MetaV1 from "jsr:@cloudydeno/kubernetes-apis/meta/v1";
 import * as AcidZalanDoV1 from "./structs.ts";
 
 export class AcidZalanDoV1Api {
diff --git a/original/acid.zalan.do@v1/structs.ts b/fixed/acid.zalan.do@v1/structs.ts
index 3225f13..d9702df 100644
--- a/original/acid.zalan.do@v1/structs.ts
+++ b/fixed/acid.zalan.do@v1/structs.ts
@@ -1,7 +1,7 @@
 // Autogenerated Schema file for AcidZalanDoV1
 import * as c from "jsr:@cloudydeno/kubernetes-apis/common.ts";
 
-import * as MetaV1 from "jsr:@cloudydeno/kubernetes-apis/builtin/meta@v1/structs.ts";
+import * as MetaV1 from "jsr:@cloudydeno/kubernetes-apis/meta/v1";
 type ListOf<T> = {
   metadata: MetaV1.ListMeta;
   items: Array<T>;
@@ -132,14 +132,14 @@ export interface postgresql {
       limits?: {
         cpu?: string | null;
         memory?: string | null;
-        hugepages-2Mi?: string | null;
-        hugepages-1Gi?: string | null;
+        'hugepages-2Mi'?: string | null;
+        'hugepages-1Gi'?: string | null;
       } | null;
       requests?: {
         cpu?: string | null;
         memory?: string | null;
-        hugepages-2Mi?: string | null;
-        hugepages-1Gi?: string | null;
+        'hugepages-2Mi'?: string | null;
+        'hugepages-1Gi'?: string | null;
       } | null;
     } | null;
     schedulerName?: string | null;

@danopia danopia marked this pull request as ready for review October 15, 2024 07:05
@danopia
Copy link
Member Author

danopia commented Oct 15, 2024

@elee1766 maybe you'd like to test with this :)
can run the new version from github: https://raw.githubusercontent.com/cloudydeno/deno-kubernetes_apis/refs/heads/codegen-fixups/generation/run-on-crds.ts

I'll add some release notes and tag a patch release later today

@danopia danopia merged commit 9760fdc into main Oct 16, 2024
6 checks passed
@danopia danopia deleted the codegen-fixups branch October 16, 2024 19:55
@elee1766
Copy link

just got to trying this.

its happy now. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants