fix(volo-http): use Option<CallOpt> rather than CallOpt
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWhiteWu
previously approved these changes
Aug 1, 2024
yukiiiteru
force-pushed
the
fix/option-callopt
branch
2 times, most recently
from
83294f9 to
34b881c
Compare
In the previous code, if there was a default `Target` and the request only had a `CallOpt` set, the new `CallOpt` would have no effect because the request had no `Target`. This commit fixes this by replacing `CallOpt` with `Option<CallOpt>`. If we use the default target and there is only one `CallOpt`, we will use it directly, otherwise the target `CallOpt` will be used. If the request target is used, the default `CallOpt` will have no effect. Signed-off-by: Yu Li <[email protected]>
yukiiiteru
force-pushed
the
fix/option-callopt
branch
from
34b881c to
44de784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the previous code, if there was a default
Targetand the request only had aCallOptset, the newCallOptwould have no effect because the request had noTarget.Solution
This commit fixes this by replacing
CallOptwithOption<CallOpt>. If we use the default target and there is only oneCallOpt, we will use it directly, otherwise the targetCallOptwill be used. If the request target is used, the defaultCallOptwill have no effect.