chore(volo-http): refactor client target #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the previous `Target` implementation was confusing and complicated, we refactored `Target` to support chain calls, which is more elegant and easy to use. In addition, we removed `TypeMap` and `FastStrMap` in `Target` and added `CallOpt`. Its usage is similar, but it is simpler and more elegant. Signed-off-by: Yu Li <[email protected]>
yukiiiteru
force-pushed
the
chore/refactor-client-target
branch
from
21f76ff to
fb340cc
Compare
PureWhiteWu
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous
Targetimplementation was confusing and complicated.Solution
We refactored
Targetto support chain calls, which is more elegant and easy to use.In addition, we removed
TypeMapandFastStrMapinTargetand addedCallOpt. Its usage is similar, but it is simpler and more elegant.