-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor error to be more clear and maintainable #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWhiteWu
added
A-volo-build
This issue concerns the `volo-build` crate.
A-volo-thrift
The issue concerns the `volo-thrift` crate.
labels
Feb 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
PureWhiteWu
force-pushed
the
refactor/error
branch
from
February 18, 2024 09:31
904494f
to
5df6ce9
Compare
PureWhiteWu
force-pushed
the
refactor/error
branch
from
February 19, 2024 07:18
5df6ce9
to
1ff818a
Compare
Millione
previously approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-volo-build
This issue concerns the `volo-build` crate.
A-volo-thrift
The issue concerns the `volo-thrift` crate.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
目前的实现具有以下问题:
Solution
这个 PR 完成了以下更改:
具体来看,在 Server 端,无论是 Handler 还是 Service 中,错误类型为:
在 Client 端,错误类型为: