fix(volo-build): escape keywords in code generation for idl service method arguments #863
Ggiggledependency-review.yaml
on: pull_request
dependency-review
17s
Annotations
5 warnings
|
dependency-review
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/dependency-review-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
`self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult:
examples/src/thrift/hello/server_panic.rs#L23
warning: `self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult
--> examples/src/thrift/hello/server_panic.rs:23:9
|
23 | &self,
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument
= note: `#[warn(clippy::duplicate_underscore_argument)]` on by default
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
benchmark/src/perf/mem.rs#L62
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> benchmark/src/perf/mem.rs:62:41
|
62 | mem_usage_list.push(mem_usage as u64);
| ^^^^^^^^^^^^^^^^ help: try: `mem_usage`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
elided lifetime has a name:
volo-http/src/server/route.rs#L482
warning: elided lifetime has a name
--> volo-http/src/server/route.rs:482:65
|
482 | fn at<'a>(&'a self, path: &'a str) -> Result<matchit::Match<&RouteId>, MatcherError> {
| -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a`
|
|
elided lifetime has a name:
volo-http/src/server/route.rs#L482
warning: elided lifetime has a name
--> volo-http/src/server/route.rs:482:64
|
482 | fn at<'a>(&'a self, path: &'a str) -> Result<matchit::Match<&RouteId>, MatcherError> {
| -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a`
|
= note: `#[warn(elided_named_lifetimes)]` on by default
|