Skip to content

feat(http): support websocket server #821

feat(http): support websocket server

feat(http): support websocket server #821

Triggered via pull request August 7, 2024 07:50
Status Success
Total duration 20s
Artifacts

dependency-review.yaml

on: pull_request
dependency-review
13s
dependency-review
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 2 warnings
conflicting implementations of trait `server::utils::ws::Callback` for type `server::utils::ws::DefaultCallback`: volo-http/src/server/utils/ws.rs#L213
error[E0119]: conflicting implementations of trait `server::utils::ws::Callback` for type `server::utils::ws::DefaultCallback` --> volo-http/src/server/utils/ws.rs:213:1 | 168 | / impl<Fut, C> Callback for C 169 | | where 170 | | Fut: Future<Output = ()> + Send + 'static, 171 | | C: FnOnce(WebSocket) -> Fut + Send + 'static, 172 | | C: Copy, | |____________- first implementation here ... 213 | impl Callback for DefaultCallback { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `server::utils::ws::DefaultCallback`
unresolved import `tokio_tungstenite`: volo-http/src/server/utils/ws.rs#L47
error[E0432]: unresolved import `tokio_tungstenite` --> volo-http/src/server/utils/ws.rs:47:5 | 47 | use tokio_tungstenite::{ | ^^^^^^^^^^^^^^^^^ use of undeclared crate or module `tokio_tungstenite`
failed to resolve: use of undeclared crate or module `tokio_tungstenite`: volo-http/src/server/utils/ws.rs#L47
error[E0433]: failed to resolve: use of undeclared crate or module `tokio_tungstenite` --> volo-http/src/server/utils/ws.rs:47:5 | 47 | use tokio_tungstenite::{ | ^^^^^^^^^^^^^^^^^ use of undeclared crate or module `tokio_tungstenite`
dependency-review
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/dependency-review-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
casting to the same type is unnecessary (`u64` -> `u64`): benchmark/src/perf/mem.rs#L62
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> benchmark/src/perf/mem.rs:62:41 | 62 | mem_usage_list.push(mem_usage as u64); | ^^^^^^^^^^^^^^^^ help: try: `mem_usage` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default