fix: escape keyword when resolving path in workspace (#212)

fix: escape keyword when resolving path in workspace mode Co-authored-by: $wangjie.wjdew <[email protected]>
cloudwego · Nov 13, 2023 · f854364 · f854364
1 parent 2c0ecc7
commit f854364
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/pilota-build/Cargo.toml b/pilota-build/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "pilota-build"
-version = "0.9.6"
+version = "0.9.7"
 edition = "2021"
 description = "Compile thrift and protobuf idl into rust code at compile-time."
 documentation = "https://docs.rs/pilota-build"

diff --git a/pilota-build/src/middle/resolver.rs b/pilota-build/src/middle/resolver.rs
@@ -84,20 +84,20 @@ impl PathResolver for DefaultPathResolver {
         #[derive(Debug)]
         enum Kind {
             Super,
-            Ident(FastStr),
+            Ident(Symbol),
         }
 
         let path = (0..p1.len() - i)
             .map(|_| Kind::Super)
-            .chain((i..p2.len()).map(|i| Kind::Ident(p2[i].clone().0)))
+            .chain((i..p2.len()).map(|i| Kind::Ident(p2[i].clone())))
             .collect::<Vec<_>>();
 
         let _length = path.len();
 
         for (_idx, k) in path.into_iter().enumerate() {
             segs.push(match k {
                 Kind::Super => "super".into(),
-                Kind::Ident(ident) => Symbol::from(ident).to_string(),
+                Kind::Ident(ident) => ident.to_string(),
             });
         }
         segs.into_iter().join("::").into()
@@ -135,10 +135,7 @@ impl PathResolver for WorkspacePathResolver {
         if p2[0] == p1[0] {
             DefaultPathResolver.related_path(p1, p2)
         } else {
-            let mut segs = vec![];
-            p2.iter().for_each(|s| segs.push(s.clone()));
-
-            format!("::{}", segs.join("::")).into()
+            format!("::{}", p2.iter().map(|s| s.to_string()).join("::")).into()
         }
     }
 }