Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: trace doFinish multiple times #989

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Nov 6, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

优化trace中 dofinish 执行多次的情况

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: 优化trace中 dofinish 执行多次的情况
zh(optional): 用户使用短连接的时候,trace.DoFinish 会执行多次,导致上报重复的情况

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners November 6, 2023 06:57
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e02c162) 81.86% compared to head (014affc) 81.86%.

❗ Current head 014affc differs from pull request most recent head 0639f55. Consider uploading reports for the commit 0639f55 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #989   +/-   ##
========================================
  Coverage    81.86%   81.86%           
========================================
  Files           98       98           
  Lines         9932     9932           
========================================
  Hits          8131     8131           
  Misses        1311     1311           
  Partials       490      490           
Files Coverage Δ
pkg/protocol/http1/server.go 72.24% <0.00%> (-0.96%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FGYFFFF FGYFFFF merged commit 66f5338 into cloudwego:develop Nov 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants