Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(hz): thriftgo option transfer #988

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Nov 6, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

优化透传 thriftgo 选项优先级的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: optimize thriftgo option transfer
zh(optional): 优化 thriftgo 透传 option 的优先级问题;thriftgo 的 option 以后写入的为准,之前写法把 hz 默认携带的 option 放到了后面,导致用户无法覆盖这些 option

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners November 6, 2023 03:09
@FGYFFFF FGYFFFF changed the title optimize: thriftgo option transfer optimize(hz): thriftgo option transfer Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e02c162) 81.86% compared to head (7abf87b) 81.86%.

❗ Current head 7abf87b differs from pull request most recent head c034a0b. Consider uploading reports for the commit c034a0b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #988   +/-   ##
========================================
  Coverage    81.86%   81.86%           
========================================
  Files           98       98           
  Lines         9932     9932           
========================================
  Hits          8131     8131           
  Misses        1311     1311           
  Partials       490      490           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF merged commit 4e9bafb into cloudwego:develop Nov 13, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants