Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(hz): slice method for thrift #986

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Nov 3, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

优化 thrift IDL 声明接口路由的方式

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional): thrift 的接口定义可指定多个相同的 http method 定义,例如
(api.get="/hello", api.get="hello2", api.get="hello3");

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners November 3, 2023 07:07
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e02c162) 81.86% compared to head (ff614f7) 81.78%.
Report is 7 commits behind head on develop.

❗ Current head ff614f7 differs from pull request most recent head 65a9e10. Consider uploading reports for the commit 65a9e10 to get more accurate results

Files Patch % Lines
pkg/protocol/uri.go 81.81% 3 Missing and 1 partial ⚠️
pkg/route/engine.go 40.00% 2 Missing and 1 partial ⚠️
pkg/protocol/header.go 0.00% 2 Missing ⚠️
pkg/protocol/http1/server.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #986      +/-   ##
===========================================
- Coverage    81.86%   81.78%   -0.09%     
===========================================
  Files           98       98              
  Lines         9932     9963      +31     
===========================================
+ Hits          8131     8148      +17     
- Misses        1311     1322      +11     
- Partials       490      493       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/hz/thrift/ast.go Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF force-pushed the optimize/method_slice branch 2 times, most recently from e535441 to 305adc9 Compare November 14, 2023 03:04
cmd/hz/thrift/ast.go Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF force-pushed the optimize/method_slice branch from 305adc9 to 65a9e10 Compare November 14, 2023 04:51
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@FGYFFFF FGYFFFF merged commit 171630c into cloudwego:develop Nov 14, 2023
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants