Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WithDisableDefaultDate, WithDisableDefaultContentType for server config options #985

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

Skyenought
Copy link
Contributor

@Skyenought Skyenought commented Nov 3, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional): 给 hertz 添加禁止响应头添加 date 字段和 content-type 字段的选项,主要用于对齐 fasthttp 和 fiber

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1279f53) 81.80% compared to head (ffa431b) 81.81%.

❗ Current head ffa431b differs from pull request most recent head 4dba55c. Consider uploading reports for the commit 4dba55c to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #985   +/-   ##
========================================
  Coverage    81.80%   81.81%           
========================================
  Files           98       98           
  Lines         9947     9963   +16     
========================================
+ Hits          8137     8151   +14     
- Misses        1317     1319    +2     
  Partials       493      493           
Files Coverage Δ
pkg/app/server/option.go 98.82% <100.00%> (+0.05%) ⬆️
pkg/common/config/option.go 100.00% <100.00%> (ø)
pkg/protocol/http1/server.go 72.51% <100.00%> (+0.26%) ⬆️
pkg/route/engine.go 61.43% <100.00%> (+0.15%) ⬆️
pkg/protocol/header.go 77.81% <0.00%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Duslia
Duslia previously approved these changes Nov 6, 2023
li-jin-gou
li-jin-gou previously approved these changes Nov 6, 2023
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit 837aa65 into cloudwego:develop Nov 13, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants