Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: prebind without content-length #984

Closed

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Oct 31, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

优化 prebind 的判断条件

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:optimize prebind without content-length
zh(optional): 优化 prebind 的判断条件
一些场景下会将 content-length 置为0,导致 prebind 在进行预绑定的时候只根据 content-length 判断会漏掉一些 body

(Optional) Which issue(s) this PR fixes:

#983

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners October 31, 2023 06:31
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e02c162) 81.86% compared to head (6e7d8e5) 81.83%.

❗ Current head 6e7d8e5 differs from pull request most recent head 1f11b70. Consider uploading reports for the commit 1f11b70 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #984      +/-   ##
===========================================
- Coverage    81.86%   81.83%   -0.04%     
===========================================
  Files           98       98              
  Lines         9932     9932              
===========================================
- Hits          8131     8128       -3     
- Misses        1311     1314       +3     
  Partials       490      490              
Files Coverage Δ
pkg/app/server/binding/default.go 82.60% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF force-pushed the optimize/prebind_for_content_length branch from e135aff to 1f11b70 Compare October 31, 2023 06:34
@FGYFFFF FGYFFFF closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants