Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: param router doesn't match param #978

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Oct 23, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复参数路由参数不匹配的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: When registering longer parameter routes before shorter ones, the parameters may not match.
zh(optional): 当先注册较长的参数路由,再注册较短的参数路由时,参数可能不匹配

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@Duslia Duslia requested review from a team as code owners October 23, 2023 07:11
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e02c162) 81.86% compared to head (e55030a) 81.86%.

❗ Current head e55030a differs from pull request most recent head f7e93aa. Consider uploading reports for the commit f7e93aa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #978      +/-   ##
===========================================
- Coverage    81.86%   81.86%   -0.01%     
===========================================
  Files           98       98              
  Lines         9932     9931       -1     
===========================================
- Hits          8131     8130       -1     
  Misses        1311     1311              
  Partials       490      490              
Files Coverage Δ
pkg/route/tree.go 96.67% <100.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@welkeyever welkeyever merged commit 67ca073 into cloudwego:develop Nov 14, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants