Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: validate config #955

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Sep 22, 2023

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

重构参数校验的配置行为

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: refactor the config for validating
zh(optional): 重构参数校验的配置行为

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners September 22, 2023 07:49
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a924461) 81.84% compared to head (a9e87b9) 81.92%.

❗ Current head a9e87b9 differs from pull request most recent head efd0546. Consider uploading reports for the commit efd0546 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #955      +/-   ##
===========================================
+ Coverage    81.84%   81.92%   +0.07%     
===========================================
  Files           98       98              
  Lines         9900     9926      +26     
===========================================
+ Hits          8103     8132      +29     
+ Misses        1311     1307       -4     
- Partials       486      487       +1     
Files Coverage Δ
pkg/app/server/option.go 98.76% <100.00%> (+0.03%) ⬆️
pkg/common/config/option.go 100.00% <ø> (ø)
pkg/app/server/binding/config.go 81.39% <40.00%> (+10.28%) ⬆️
pkg/route/engine.go 61.64% <66.66%> (+0.05%) ⬆️
pkg/app/server/binding/default.go 82.60% <83.33%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jin-gou
li-jin-gou previously approved these changes Sep 22, 2023
pkg/route/engine.go Outdated Show resolved Hide resolved
pkg/route/engine.go Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF changed the title fix: set validator error config refactor: validate config Sep 22, 2023
@FGYFFFF FGYFFFF force-pushed the fix/set_validator_error branch 2 times, most recently from 95bd7dc to f694ddd Compare September 22, 2023 10:11
@FGYFFFF FGYFFFF force-pushed the fix/set_validator_error branch from f694ddd to efd0546 Compare September 26, 2023 03:06
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FGYFFFF FGYFFFF merged commit 8bc1407 into cloudwego:develop Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants