Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disable normalizing #940

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

welkeyever
Copy link
Member

@welkeyever welkeyever commented Sep 9, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@welkeyever welkeyever requested review from a team as code owners September 9, 2023 02:46
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.02% ⚠️

Comparison is base (59196eb) 82.07% compared to head (c071f60) 82.06%.

❗ Current head c071f60 differs from pull request most recent head 0916db7. Consider uploading reports for the commit 0916db7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #940      +/-   ##
===========================================
- Coverage    82.07%   82.06%   -0.02%     
===========================================
  Files           97       97              
  Lines         9652     9663      +11     
===========================================
+ Hits          7922     7930       +8     
- Misses        1254     1257       +3     
  Partials       476      476              
Files Changed Coverage Δ
pkg/protocol/header.go 77.98% <0.00%> (-0.17%) ⬇️
pkg/protocol/http1/server.go 73.20% <0.00%> (-1.07%) ⬇️
pkg/app/server/option.go 98.63% <100.00%> (+0.03%) ⬆️
pkg/common/config/option.go 100.00% <100.00%> (ø)
pkg/route/engine.go 60.75% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@welkeyever welkeyever force-pushed the feat/add_disable_normalizing branch 2 times, most recently from fa014cb to b04f1ac Compare September 9, 2023 03:47
FGYFFFF
FGYFFFF previously approved these changes Sep 21, 2023
@welkeyever welkeyever force-pushed the feat/add_disable_normalizing branch from b04f1ac to e9ac181 Compare September 21, 2023 08:17
@welkeyever welkeyever merged commit 02112cc into develop Sep 21, 2023
@welkeyever welkeyever deleted the feat/add_disable_normalizing branch September 21, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants