Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export ErrMissingFile #1141

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat: export ErrMissingFile #1141

merged 1 commit into from
Jul 24, 2024

Conversation

kamikazechaser
Copy link
Contributor

What type of PR is this?

  • feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

Description

This follows the std library approach: https://pkg.go.dev/net/http#ErrMissingFile

@kamikazechaser kamikazechaser requested review from a team as code owners June 20, 2024 04:45
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

welkeyever
welkeyever approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Duslia Duslia merged commit 72cfd01 into cloudwego:develop Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duslia Duslia Duslia approved these changes

@welkeyever welkeyever welkeyever approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export errMissingFile error type
4 participants
@kamikazechaser @CLAassistant @welkeyever @Duslia